azerothcore-wotlk icon indicating copy to clipboard operation
azerothcore-wotlk copied to clipboard

fix(DB/Creature): Add a small event for mission 1781

Open fangshun2004 opened this issue 10 months ago • 1 comments

Changes Proposed:

After accepting the quest 1781 , a small event is triggered Videos from Blizzard servers: https://github.com/azerothcore/azerothcore-wotlk/assets/49193927/b4236172-db66-4c3d-9f8e-2a96fd45cf93

This PR proposes changes to:

  • [ ] Core (units, players, creatures, game systems).
  • [ ] Scripts (bosses, spell scripts, creature scripts).
  • [x] Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • [x] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • [x] Sniffs (remember to share them with the open source community!)
  • [x] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • [ ] The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • [x] Tested in-game by the author.
  • [ ] Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • [ ] This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • [ ] This pull request can be tested by following the reproduction steps provided in the linked issue
  • [ ] This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. Create an alliance of paladins
  2. .go c 39536
  3. .level 12+
  4. quest add 1780
  5. Complete the quest Accept the new quest 1781
  6. Creature 5189 on the podium will heal 6173

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

fangshun2004 avatar Apr 13 '24 16:04 fangshun2004

just tested this.

create human paladin
.level 11
.go c 39536
.quest add 1780
turn in quest "The Tome of Divinity"
accept follow-up quest "The Tome of Divinity"
observe RP

looks good :) RP looks like the video provided.

sudlud avatar Apr 15 '24 19:04 sudlud

After my testing, it works very well.

pvp100com avatar Apr 24 '24 03:04 pvp100com

Thanks to all who participated.

pangolp avatar Apr 24 '24 07:04 pangolp