Pandurang Patil
Pandurang Patil
I think issue #208 and this ticket is related
Got stuck in another call. In the process of updating the description.
@DavidBakerEffendi what is the solution? cc: @fabsx00
@hiteshbedre I am reducing the priority for this ticket as this one is no more a blocker
> @pandurangpatil Can we think of `StatsRecorder` as a trait instead of a class, which ever pass or class needs to use this functionality can do `class IdentifierTagger(cpg: Cpg) with...
> > Good idea, @mpollmeier could you give this a look? I recall some basic metrics captured in ODB but not sure if it's done at this level to include...
> mostly +1 to what David said > > It'd be useful to have a minimised integration test, e.g. run the `io.shiftleft.mypass.SamplePass` (or similar) and verify that the measurements work...
@DavidBakerEffendi @mpollmeier I have added comprehensive documentation to the file which will try to explain the implementation. Let me know if you have further questions. I have also addressed the...
>+1 for what David said - currently this is global mutable state, which may be accessed and modified by concurrently running CpgPasses. (yes, currently they run in sequence, but the...
@DavidBakerEffendi @mpollmeier We have to record the data from start to end. we need to make sure we initialise it outside any of the passes and end it towards the...