Waylon Peng comments

Repositories
Issues
Comments

Results 4 comments of


                                            Waylon Peng

MySQL queries should wrap set operations

The example you provided uses `MSSQLQuery` instead of `MySQLQuery`. Here's an example: ```py from pypika.dialects import MySQLQuery query = MySQLQuery.from_("table").select("id").union(MSSQLQuery.from_("another_table").select("id")) query.get_sql() # or str(query) ``` results in ``` SELECT `id`...

MySQL queries should wrap set operations

The temporary solution works, thanks. I opened a PR: https://github.com/kayak/pypika/pull/782

Make MySQL queries wrap set operations with parens

Gotcha, just added the tests back.

discovered_server_cb expected as a coroutine but called as a sync function

It looks like this was fixed by https://github.com/nats-io/nats.py/commit/06735d7d49af72b77ef0289d44dd868b8552fc5f.