pandaninjas

Results 28 comments of pandaninjas

> I am not sure if Prism is the right place to inject stuff into log4j. Generally, we should never modify behavior of the game or at the very least...

> GitHub has leaked my "private" email address again joy. I find this ironic on a PR regarding security. You can turn on email privacy in your GitHub profile. If...

> > Prism Launcher already seems to censor session IDs by replacing it with . This is also reflected in the uploaded log. This actually works slightly better since it...

> I am kinda unsure here. This code seems fairly intrusive. Couldn't we just use log4j configurations instead? > > This is an example config provided by Mojang to mitigate...

The most recent commits changes it to use a log4j config file

> Recently, someone mentioned in our Discord or Matrix channels that regex-based filters might not be the best way to filter logs. They can be a major performance hit, especially...

> Hey @pandaninjas, it feels like when enabling `strict mode` I'd expect things to fail if the Base64 isn't padded correctly. Is there a reason you think it shouldn't? The...

Though now that I think about it there's probably a better way to do it.

My PR might not work just yet: see https://github.com/thefightagainstmalware/NoSession/actions/runs/7545330082/job/20540724782. This issue might not just be moving the same file from source to destination, it might also be moving a parent...

> I'll see if the e2e tests fail. If they do, I'll revert :) The e2e test probably won't fail, but the PR doesn't do what it set out to...