slsa-github-generator icon indicating copy to clipboard operation
slsa-github-generator copied to clipboard

[feature] e2e tests for #3083

Open laurentsimon opened this issue 1 year ago • 5 comments
trafficstars

Need to close the loop and add e2e2 tests for https://github.com/slsa-framework/slsa-github-generator/pull/3083

laurentsimon avatar Jan 16 '24 16:01 laurentsimon

/cc @ramonpetgrave64

laurentsimon avatar Jan 16 '24 16:01 laurentsimon

My PR might not work just yet: see https://github.com/thefightagainstmalware/NoSession/actions/runs/7545330082/job/20540724782. This issue might not just be moving the same file from source to destination, it might also be moving a parent directory into a child (or vice versa)

pandaninjas avatar Jan 16 '24 17:01 pandaninjas

I'll see if the e2e tests fail. If they do, I'll revert :)

laurentsimon avatar Jan 16 '24 18:01 laurentsimon

I'll see if the e2e tests fail. If they do, I'll revert :)

The e2e test probably won't fail, but the PR doesn't do what it set out to accomplish.

pandaninjas avatar Jan 16 '24 18:01 pandaninjas

ah you're right! Let me revert now then

laurentsimon avatar Jan 16 '24 18:01 laurentsimon

I think this is fixed. Closing

laurentsimon avatar Apr 18 '24 16:04 laurentsimon