Taehoon Moon
Taehoon Moon
> > changes in `storages/memory_storage/src/{alter_table}|{lib}.rs` does not look related to this PR. could we have this in a different pr? > > Could you kindly reference the changes? sure, these...
> > > > changes in `storages/memory_storage/src/{alter_table}|{lib}.rs` does not look related to this PR. could we have this in a different pr? > > > > > > > >...
> > > > > > changes in `storages/memory_storage/src/{alter_table}|{lib}.rs` does not look related to this PR. could we have this in a different pr? > > > > > >...
big ones all look great so I think from now, like this, I may suggest some small cleanups or refactoring stuffs. I will leave comments.
formatting configuration should not be changed here. that is not related to this pr. we need to handle it separately. and.. you should not change the toolchain from stable to...
> > formatting configuration should not be changed here. that is not related to this pr. we need to handle it separately. and.. you should not change the toolchain from...
I've run into similar lifetime issues with other crates before, so I understand the pain point. Honestly, there was no intentional reason for `'static` here - just an oversight when...
This looks like a **performance/operational** issue (async runtime fairness / tail latency), **not** a **safety/correctness** bug. * On `main`, `Send`/`Sync` is resolved. Using a single Glue instance across threads with...
I think I understand much better now. When you first opened this issue I didn’t fully grasp your point - I was mixing up “it compiles” with “it is correct,”...
The function implementation looks good overall! However, since we already support the `HEX` function, it would be more consistent if `UNHEX` acted as its reverse counterpart. Currently, `HEX` converts a...