Taehoon Moon
Taehoon Moon
Thank you for your question! Currently, GlueSQL has a preliminary implementation for custom scalar and aggregate functions through optional store traits: `CustomFunction` and `CustomFunctionMut`. You can see an example of...
it looks that between 0.46 and 0.50 has too many breaking changes in sqlparser. could we split this into small steps? I see that 0.47 has some AST changes including...
Yes, you are correct that composite primary keys are not supported at this time. Implementing this feature requires significant changes in the core areas, including the AST, planner, and execution...
There are different approaches, but here's a method I personally recommend: 1. **Test Suite**: Start by finding the primary key tests in the test suite and add integration tests for...
> In this enum, shouldn't there be more options? > > https://github.com/gluesql/gluesql/blob/25309dd15a50ee061e714576079b2cd8c1fcca9c/core/src/ast/mod.rs#L43-L46 it can have more, but not yet supported.
> Where in the code is the unique constraint enforced currently? here. it includes both clustered (primary key) and non-clustered index validation codes. it would be enough to focus on...
> @panarch now several storages pass the test suite. How would I go about and test the remaining storage, like redis and IDB storage? idb storage - https://github.com/gluesql/gluesql/blob/main/storages/idb-storage/README.md you need...
Great start! The initial tests look good. Could we also include unit tests in the primary_key planner found [here](https://github.com/gluesql/gluesql/blob/main/core/src/plan/primary_key.rs)? This will help us precisely verify the functionality of composite primary...
Looks good. It seems you're familiar with the concepts of storage and the test suite. Now, it would be more efficient to focus solely on the core workspace. Once we...
ref. https://github.com/gluesql/gluesql/blob/25309dd15a50ee061e714576079b2cd8c1fcca9c/core/src/ast/ddl.rs#L32-L40 ColumnDef currently holds information for a single column. Therefore, if we enable composite primary keys, the primary key field should not remain within ColumnDef. It seems necessary to...