Oleksandr Hulyi

Results 90 comments of Oleksandr Hulyi

Hi @arontsang! Do you mean advice argument ```Attribute[]``` and use ```ReadOnlySpan``` instead to avoid allocations for the collection itself? If yes, then my thoughts are that I'm not sure it...

I was thinking about it. What if we preallocate object[] on the heap and then reuse it? This way: - allocation happens only ones per method - api still has...

agree to both. I do think ReadOnlySpan makes a lot of sense. It could be probably an option for user to decide which API to use. And it will simplify...

Hi @arontsang , you are right. Actual benchmarks show that performance difference is big enough. ``` | Method | Job | Runtime | Mean | Error | StdDev | Ratio...

Sorry for delay, was on vacation) Yes - generics are tricky, half of all bugs in this project are generics related. For example you can take a look at [here](https://github.com/pamidur/aspect-injector/blob/734241dcf5bb5ef98e5e039765d624daac7f6a7a/src/AspectInjector.Core.Advice/Weavers/Processes/AfterStateMachineWeaveProcessBase.cs#L34)....

Hi @arontsang Well done! Could you make it a PR ? Regarding missing things: - Naming can be done the same way it is done for around method -> Take...

> > > If Aspect around the method, it will generate code like: > > ```cs > private object __a$_around_Method_100663472_w_0(object[] A_1) > { > return this.Aspect.Around(new Func(this.__a$_around_Method_100663472_u), A_1); > }...

Hi! Thanks! I'm actually working on something like this. But the idea is not the config file but kinda fluent loader. So you'll be able to do something like: ```c#...

Hi @emisand , unfortunately AspectLoader is not ready (not even close to ready as there is some technical difficulties) There is another feature though that might be of some interest...