pamapa
pamapa
@Badisi Thanks for helping reviewing. Valid concerns, which must be answered/resolved before we merge...
@DASPRiD Yes we are waiting for @kherock for his approval and please also answer to @Badisi questions...
I can not see the answers to https://github.com/authts/oidc-client-ts/pull/434#discussion_r835527285 + https://github.com/authts/oidc-client-ts/pull/434#discussion_r835532113
It would be very nice for others to see how this feature can be implemented.
@divid3byzero Please test and review
No need to make it so complicated, why not using this pattern directly in `querySessionStatus`? `id_token_hint: this.settings.includeIdTokenInSilentRenew ? user?.id_token : undefined,` -> ```js const handle = await this._iframeNavigator.prepare({ silentRequestTimeoutInSeconds });...
Please squash commits and avoid changes style changes.
Yes, the code style checking should be improved, but not in this MR :-) The build pipeline fails with this: ``` npm run build ... Analysis will use the bundled...
For now, as you do not need to change the api file in this MR, simply revert the whole `oidc-client-ts.api.md` file changes...
Its coming from `.husky/pre-commit`. You can temporary disable the commands inside. Alternate i can hijack your MR and do it, lets try the first option first :-)