pamapa comments

Results 411 comments of


                                            pamapa

reinstate clock service

@kherock I have problems with the unit-tests when i make the ClockService getEpochTime async. Any idea?

reinstate clock service

I will drop the DateUtils and use instead ClockService as well. I would prefer a non promise callback solution, what do you think?

reinstate clock service

Cosmetic: I was thinking at which position of the functions i should add the clockService parameter. I decided against putting it into `args` object (e.g. SigninRequest) as it should not...

reinstate clock service

I am going to split this MR, the first one reinstate the clock service, the second then goes beyond what oidc-client-js does. The first part should be simple and is...

reinstate clock service

Other much simpler solution: Lets make `Timer.getEpochTime` changeable. I first thought because it is static, it is not such a good idea, but the use-case for this (#414) is to...

fix(UserManager): handle concurrent token refresh requests via leader election

Great work , thanks for the fast response! Do we really need the `broadcast-channel` library, modern browsers support the `broadcast-channel` feature natively. When i look into https://developer.mozilla.org/en-US/docs/Web/API/Broadcast_Channel_API: - IE has...