Koncz Levente comments

Results 8 comments of


                                            Koncz Levente

Fix level 3 MSVC warnings in public headers

Sorry, we got swamped with other urgent tasks so opening the PR got a bit delayed, but we will get to it soon (this week 🤞 )! As for the...

Import native vertex/index buffers into buffer objects

Meanwhile I found that [you removed](https://github.com/google/filament/pull/6360/files#diff-da6dc85d2fb7e75d569afdeaa4558737c6fd5993d645dcf2f535819ce3a6baf9L306) `cancelExternalImage` too

Import native vertex/index buffers into buffer objects

For illustration I added: - a branch with the proposed API changes, but no implementation: https://github.com/google/filament/compare/main...shapr3d:filament:import_native_buffers - another branch with a Metal implementation and a unit test: https://github.com/shapr3d/filament/compare/import_native_buffers...shapr3d:filament:import_native_buffers_mtl Now adding...

API for importing native buffers as buffer objects

Preview for a possible Metal implementaiton: https://github.com/shapr3d/filament/compare/import_native_buffers...shapr3d:filament:import_native_buffers_mtl

API for importing native buffers as buffer objects

Since this PR diverged from `main`, I close it. Can be reopened anytime if needed.

Uniform buffer loads fail on Metal backend on Intel GPUs

For the record this doesn't happen on the AMD and Apple GPUs we tested on macOS

Uniform buffer loads fail on Metal backend on Intel GPUs

Filament uses very high slot numbers for UBOs on Metal: `UNIFORM_BUFFER_BINDING_START` is 17. Based on the Metal Feature Set Tables, the _Maximum number of constant buffer arguments in vertex, fragment,...

Uniform buffer loads fail on Metal backend on Intel GPUs

I forgot to mention that none of these issues were reproducible in v1.12.8. Of course, there was no instancing support before v1.24.0 so that explains why `initObjectUniforms()` didn't cause a...