Pablo Álvarez Córdoba

Results 10 comments of Pablo Álvarez Córdoba

I think the you should pass the service, not the repository. Important: auth/user should depend upon a interface, not the implementation of PolicyService.

I don't see how it breaks rules of service pattern. Again, auth/user should use an interface not implementation. And maybe you could simply do a Policy model and use it.

Suggestion: add at the end of each function in attachments.py one of this lines, depending of function signature: - `attachment["username"] = cbkwargs.get("username", "{}@{}".format(platform.node(), task.name))` - `attachment["username"] = cbkwargs.get("username", "{}@{}".format(platform.node(), task_name))`...

Well... it is used only when starting, stopping, and more but not in failed tasks. I want the hostname to be present in every message. By the way... we never...

If you are interested we can work together to solve these problems. Startup/Shutdown messages are not important for my company (at least while those messages does not give information about...

I already did it. Next Monday I will make a pull request to allow to change the username. Thanks for your quick replies and your interest.

Vim does not allow me to exit, but it is because it loves me. And it is fine because that love is mutual. Vim punches me when I try to...

@RobertCraigie Yeah, I didn't expect the issue to be solved here, although it would have been nice. As I said, this isn't a bug, but v1.3.9 broke telemetry. Shouldn't this...

@crflynn I've closed it. This is the good PR. Here I don't use tricks involving `inspect.trace`. I haven't written the tests yet.