Vladimir Dementyev

Results 293 comments of Vladimir Dementyev

This also crashes `Date._parse` (within `evalAsync`): ``` app.wasm:0x5739f8 Uncaught RuntimeError: memory access out of bounds at enc_strlen (app.wasm:0x5739f7) at rb_enc_strlen (app.wasm:0x573574) at update_char_offset (app.wasm:0x50cc96) at match_begin (app.wasm:0x507547) at ractor_safe_call_cfunc_1 (app.wasm:0x67a681)...

Okay, I found the fix 😁—https://github.com/ruby/ruby/commit/0d4de0f4b1b9ac90be437bf1bac6851dd1d96fd0: ``` Author: Yuta Saito Date: Mon Jan 29 09:49:15 2024 +0000 wasm: align fiber stack pointer to 16 bytes In WebAssembly C ABI, the...

I think, having it as a configuration option for `has_logidze` would be nice, smth like: ```ruby has_logidze aliases: {old_title_column_name: :new_title_column_name} ``` (Using "alias" to match the exiting `alias_attribute` API)

> A section like "how Logidze handles table changes" Yeah, that's a great idea for the start.

> Is there a translation layer from prism to this parsers AST somewhere? Prism supports AST translation for popular parsers: https://github.com/ruby/prism/tree/main/lib/prism/translation > And if (or once) parse.y is deprecated it...

> shouldn't it "just work" with an AST constructed by Prism's compatibility layer? Yeah, it works right now. Well, at least, for Ruby Next. I think, what could be done...

Interesting. Do you know how big was the log_data? The compaction happens in a loop by merging log entries one by one starting from the oldest one until we reach...

I mean, what's the size of the log_data for affected records? Something like: ```sql SELECT jsonb_array_length(log_data->'h') // or MAX(jsonb_array_length(log_data->'h')) FROM ; ```

> So this deviates from the ActionCable JS client a where it returns a boolean: Good catch. I think, a proper fix would be to return boolean as well (and...