Vladimir Dementyev

Results 297 comments of Vladimir Dementyev

Thanks @sanks02! Please, take a look at the RuboCop offenses (look legit) and RSpec failures. @ardecvz Waiting for your approval 🙂 (and the green CI, of course)

@sanks02 Thanks! @ardecvz I'm still waiting for your pair of eyes 👀

I think, you posted issue in the right place. We do not take scopes into account when reloading the log data: https://github.com/palkan/logidze/blob/fc891d83acbaf1179a98a5963994663f0a142eb8/lib/logidze/model.rb#L219 Adding `.unscoped` here makes senses. Or, probably, add...

> assume Logidze is tied into the model with a save callback or the like Logidze uses database triggers; so, there is no way to write metadata without touching the...

> But when I want to check the value at any version, it always returns the current version one even when it was nil in previous versions: I think, it...

> If the default value of the new column is not null, I think it should not be nulled either That's a good point; we can restore it to the...

@ardecvz any thoughts? (you're the last one who touched Redis configuration code 🙂)

Hey again, It looks like connecting to Unix Redis socket is already supported (since 1.4.5). You should be able to use `unix://tmp/redis/redis.sock` as the `REDIS_URL` value. Please, let me know...

Hey @lcmen, Can you please post the full output with the error?

> It seems that the old Redis lib Redigo also https://github.com/gomodule/redigo/pull/669 so I could patch the default broadcaster too if @palkan hasn't done it already and is OK with the...