Vladimir Dementyev

Results 297 comments of Vladimir Dementyev

Hey @composerinteralia > It would also be great if we could track queries or transactions to a different database cluster Added here https://github.com/palkan/isolator/commit/7824716033c82125bc7f23908410c87a638dd3de

Hey @ocvit! Thanks for the detailed explanation. I suggest extracting the `offense.disabled?` check into a separate PR (this is a bug fix, we can merge it quickly) and figure out...

> Should the generator have automatically added the config_name: api_service setting to the generated config class? Yeah, that's a good suggestion. Added. Will be released in 2.5.0.

Under the hood, we use `at(time:)` when loading associations. I think, that can be the reason for inconsistency. That's why I need `log_data` contents to figure out what went wrong.

Thanks @brunoprietog! Looks like I'm out of questions/suggestions 😁 @rafaelfranca @matthewd Looking for someone with merge permissions for the final review 🙂

Thanks for reporting. Do you see this problem in development or other env? I think, it could be related to code reloading. Can you try disabling code reloading (`config.cache_classes =...

I pushed a fix to master, could you please check it out?

We have no assumptions on I18n backend, we simply call `I18n.t`: https://github.com/palkan/action_policy/blob/04a579088846e8f4bfba28cf37f2f0954a3e6cde/lib/action_policy/i18n.rb#L14 Can you please provide the value of the `e.result.all_details`? Also, `e.result.rule` and `e.result.policy.identifier`

Thanks for the report! Just to confirm that it relates to the `ThreadMemoized`, can you please try to turn it off and see if it helps: ```ruby ActionPolicy::PerThreadCache.enabled = false...

Thanks for the details! That will help with reproduction in tests. Also, I think it's worth extracting the minimal _behaviour_ implementation into a separate module, so it's possible to opt-out...