Ben Welsh

Results 224 comments of Ben Welsh

This proposal has been updated to act as a backport from yt-dlp, which has reviewed and accepted it. https://github.com/yt-dlp/yt-dlp/pull/4609

I've just tonight run into this bug with the Twitter extractor. You can reproduce it with the following: ```bash youtube-dl https://twitter.com/TulsiGabbard/status/1555878318469091330 [twitter] 1555878318469091330: Downloading guest token [twitter] 1555878318469091330: Downloading JSON...

Thanks for all the advice. I've made your changes and tried to apply them to #31141 and #31143 as well.

I've updated this patch to act as a backport from yt-dlp. You can find it here. https://github.com/yt-dlp/yt-dlp/pull/4616 I've left out the third test for a YouTube embed because I'm unsure...

@dirkf, I added the YouTube passthrough test back in, as you suggested. However, I'm getting #30976 when I try to test it locally. It's failing to dig out https://youtu.be/r5vkSaz8PxQ. If...

Here's the error I get: ```bash $ python test/test_download.py TestDownload.test_Parler_2 [Parler] f23b85c1-6558-470f-b9ff-02c145f28da5: Downloading JSON metadata [youtube] r5vkSaz8PxQ: Downloading webpage [youtube] r5vkSaz8PxQ: Downloading MPD manifest [youtube] r5vkSaz8PxQ: Downloading player 0c356943 ERROR:...

I pulled from master and still got it. So I think this bug is probably a phantom and the patch is ready for your review.

@dirkf, I believe I have achieved your request with a little less code. The uploader name is pretty strictly limited by Twitter, so I don't think we need to slice...

The flake errors in the test run appear to be in other files.