Palash Gupta

Results 67 comments of Palash Gupta

> @sf-pchakraborty Is this PR refactoring from a frontend side? Will end users see an impact of this? No @pranay01 this more kind of a data refactoring

I don't think it is actionable right now ... will revisit if any more insights is needed for now we close

Sure please go ahead @Vipul2504

@Aakarshan-369 there are two rules for same 1. `no-shadow:off` 1. '@typescript-eslint/no-shadow': 'off' we need to remove both of them i guess remove the first one https://github.com/SigNoz/signoz/pull/2093 can you take yup...

> should I go on and remove the `no-shadow:off` and let #2093 remove the second one ? thanks for the quick follow-up :) shared the context in the PR if...

> here @kaushikmacharla07 in the design prev logs page is missing are we removing that ?

@GeekBoySupreme can you help here

@srikanthccv can add the ruleId while we are creating the rule ? right only success message is passed current response ``` {"status":"success","data":"rule successfully added"} ``` expected response: ``` { "id":...

logic for colour assignment happens in a round-robin fashion @Rajat-Dabade can you check when we open the full view we reflect the same colours