signoz icon indicating copy to clipboard operation
signoz copied to clipboard

FE: remove `no-shadow:off` `'@typescript-eslint/no-shadow': 'off'` and rules from eslint rule list

Open palashgdev opened this issue 2 years ago • 10 comments

Bug description

Please describe.

remove this rule from eslint

palashgdev avatar Jan 22 '23 12:01 palashgdev

Currently there are 86 issues regarding this rule

palashgdev avatar Jan 22 '23 12:01 palashgdev

Hi! I'm a new comer here and saw this good-first-issue. I was interested to know how I should go about solving it. I see the no-shadow:off rule in the signoz/frontend/.eslintrc.js Thanks!

Aakarshan-369 avatar Jan 22 '23 15:01 Aakarshan-369

@Aakarshan-369 there are two rules for same

  1. no-shadow:off
  2. '@typescript-eslint/no-shadow': 'off'

we need to remove both of them i guess remove the first one https://github.com/SigNoz/signoz/pull/2093 can you take yup the second one ?

palashgdev avatar Jan 23 '23 11:01 palashgdev

should I go on and remove the no-shadow:off and let #2093 remove the second one ? thanks for the quick follow-up :)

Aakarshan-369 avatar Jan 23 '23 11:01 Aakarshan-369

should I go on and remove the no-shadow:off and let #2093 remove the second one ? thanks for the quick follow-up :)

shared the context in the PR if you have any doubt

palashgdev avatar Jan 23 '23 12:01 palashgdev

is this issue resolved?

saadahmadhere avatar Mar 08 '23 12:03 saadahmadhere

@palashgdev #2670 closes this issue.

Please check and let me know

ksorv avatar May 05 '23 17:05 ksorv

@ksorv , I think this is still pending. As far as I know, #2670 was closed abruptly.

mehra-sourav avatar Oct 13 '23 12:10 mehra-sourav

@ksorv , I think this is still pending. As far as I know, #2670 was closed abruptly.

U can check the comment @mehra-sourav, in my PR.

Some code was to be fixed... but Im not sure where the problem was originating.

ksorv avatar Oct 13 '23 12:10 ksorv