signoz
signoz copied to clipboard
FE: remove `no-shadow:off` `'@typescript-eslint/no-shadow': 'off'` and rules from eslint rule list
Bug description
Please describe.
remove this rule from eslint
Currently there are 86 issues regarding this rule
Hi! I'm a new comer here and saw this good-first-issue. I was interested to know how I should go about solving it. I see the no-shadow:off
rule in the signoz/frontend/.eslintrc.js
Thanks!
@Aakarshan-369 there are two rules for same
-
no-shadow:off
- '@typescript-eslint/no-shadow': 'off'
we need to remove both of them i guess remove the first one https://github.com/SigNoz/signoz/pull/2093 can you take yup the second one ?
should I go on and remove the no-shadow:off
and let #2093 remove the second one ?
thanks for the quick follow-up :)
should I go on and remove the
no-shadow:off
and let #2093 remove the second one ? thanks for the quick follow-up :)
shared the context in the PR if you have any doubt
is this issue resolved?
@palashgdev #2670 closes this issue.
Please check and let me know
@ksorv , I think this is still pending. As far as I know, #2670 was closed abruptly.
@ksorv , I think this is still pending. As far as I know, #2670 was closed abruptly.
U can check the comment @mehra-sourav, in my PR.
Some code was to be fixed... but Im not sure where the problem was originating.