plottable

plottable copied to clipboard

rework legend code to use HTML positioning

2

Legend code is awful and overcomplicated; most of what we need is achievable through simple HTML and CSS. Use that instead.

hellochar

DRY label drawing code and move it into Drawers

1

Label drawing code is duplicated across Plots; additionally, Plots shouldn't be responsible for drawing directly to the DOM

hellochar

Update tutorials on http://plottablejs.org/

2

Tutorial is not up to date with current released version.

endrjuskr

global config objects are bad practice and don't make sense in a modularized world. Replace the "SHOW_WARNINGS" flag with what React does (only true in "dev" mode, not prod). Not...

hellochar

API: Use `TransformableScale` in XYPlots instead of simply, Scale

1

Setting x and y scales should require passed-in scales to be Transformable, not simply base scales. https://github.com/palantir/plottable/blob/develop/src/plots/xyPlot.ts#L154 https://github.com/palantir/plottable/blob/develop/src/plots/xyPlot.ts#L193

CalvinFernandez

IE11 flickers on adding new data and redomaining

7

Repro: 1. go to http://jsfiddle.net/kcju4/ 2. remove left and right, add back left and right 3. It'll flicker and redomain, instead of redomaining nicely like ff and chrome

crmorford

See #3266 for generic thinking around canvas renderers

hellochar

Plot.ts defines a fixed pipeline of 5-6 methods for Plot rendering that subclasses override. This ends up feeling awkward and repeating code (e.g. creating a drawer for each Dataset logic...

hellochar

Use real abstract classes

1

There are a few places where we use pseudo-abstract classes & methods, like `Scale#scale(value: D): R`. These ought to use the built-in language features for abstraction.

adidahiya

Enable strictNullChecks

2

CalvinFernandez