plottable icon indicating copy to clipboard operation
plottable copied to clipboard

API: Use `TransformableScale` in XYPlots instead of simply, Scale

Open CalvinFernandez opened this issue 7 years ago • 1 comments

Setting x and y scales should require passed-in scales to be Transformable, not simply base scales.

https://github.com/palantir/plottable/blob/develop/src/plots/xyPlot.ts#L154 https://github.com/palantir/plottable/blob/develop/src/plots/xyPlot.ts#L193

CalvinFernandez avatar Feb 02 '17 18:02 CalvinFernandez

Hey @CalvinFernandez can you remind me what this ticket is and why it's needed? I see we modified .x and .y() to return TransformableScales in https://github.com/palantir/plottable/pull/3159 -- why did we do that again?

hellochar avatar Mar 24 '17 23:03 hellochar