Ruwen Hahn
Ruwen Hahn
> With #10494 merged, this can be rebased and undrafted. @RytoEX: done
@RytoEX: nits should be addressed and squashed (and rebased)
> Off-thread discussion indicates that this looks good. Squash the commits appropriately and we'll give it a (hopefully) final pass. @RytoEX: squashed and rebased
> Holding this due to a confirmed issue regarding audio/video desync that is unique to this implementation. @RytoEX: I just pushed a fix for the desync, it was an issue...
> Not sure if the librtmp commit should be first or not. I wouldn't want the eRTMP multitrack audio commit to exhibit the buggy behavior, but I wasn't sure if...
> @palana Please squash the commits here. @RytoEX: done (also rebased on master)
> Commit message nit: > > > rtmp-services: Allow loading Multitrack Video configuration from services.json > > This commit message subject is too long. > > Instead, use this: >...
> This will need to be rebased. @RytoEX: done
> #10633 was merged some time ago. This will need to be rebased and get CI to pass. @RytoEX: rebased and updated the description
> @palana It looks like the build failures are still present. @RytoEX: oh, yea, missed the bit about making CI pass; latest push should make it pass 😅