manu

Results 38 comments of manu

+1 for using black for formatting

-> See my [Comment](https://github.com/initialcommit-com/git-sim/issues/23#issuecomment-1406127194) in #23

> So for the Settings, how should we decide what should be included there? I'd have it store everything that is needed in the `GitSimBaseCommand` in there (basically replacing `args`...

@initialcommit-io unfortunately this change would have to be done for all commands at once (at least I am not aware of a way to have `arparse` and `Typer` work at...

@initialcommit-io regarding the subcommands' properties like `numCommits` etc, I am a bit on the fence if we should store them in a dataclass like `Settings` (and then reference them like...

@initialcommit-io quick question: what does the `self.maxrefs` in `GitSimStatus` do? ```py class GitSimStatus(GitSimBaseCommand): def __init__(self, args: Namespace): super().__init__(args=args) self.maxrefs = 2 self.hide_first_tag = True self.allow_no_commits = True ``` When searching...

Made some progress today (long train ride), only `revert, rebase, merge, cherrypick` are left to change, as well as some cleaning up. @initialcommit-io FYI, I will be away for a...

> question about the cherrypick command/class Ah, I was not aware of that - we can just rename the function to `cherry_pick()`, underscores in function names are automatically mapped to...

Re: the pydantic Settings, see #52 :)

> Also noticed that the shorthand options like git-sim commit -m and git-sim rebase -e and git-sim -h don't work anymore. We need to add those back in. I'll have...