git-sim icon indicating copy to clipboard operation
git-sim copied to clipboard

code cleanups for python 3+

Open marksmayo opened this issue 2 years ago • 1 comments
trafficstars

  • cleaned up imports
  • added 3, 3.5, 3.6+ trailing commas
  • tidied whitespace
  • formatted with black

marksmayo avatar Jan 24 '23 02:01 marksmayo

+1 for using black for formatting

paketb0te avatar Jan 24 '23 19:01 paketb0te

Hi @marksmayo,

Thanks for this - I hadn't used black before and @paketb0te suggested we used it in a different issue they opened. I just looked into it and I think we should go for it.

But I've made some conflicting code changes since you submitted this PR. Can you pull down the updates and run your formatting again, and submit a new PR?

I'll merge that and then we can use black going forward when committing new code.

initialcommit-io avatar Jan 27 '23 07:01 initialcommit-io

-> See my Comment in #23

paketb0te avatar Jan 27 '23 07:01 paketb0te

Hi @marksmayo,

I took care of the formatting with black and committed.

If you'd like you can clean up the imports and add the trailing commas in a new PR. Not sure if the whitespace updates still apply after the reformatting with black has been done.

initialcommit-io avatar Jan 27 '23 09:01 initialcommit-io