Patrick Bänziger

Results 13 comments of Patrick Bänziger

Thanks for the input @dblessing I've used `git bisect` to figure out when the properties `user_can_approve` and `user_has_approved` were introduced. Both were present in GitLab (EE) commit 85409f275e75506eb6dea1a2985b6f644a99812e, which is...

[I've attempted](https://github.com/padyx/gitlab-plugin/compare/features/mergeRequestApproval...padyx:features/mergeRequestApprovalFlags) to implement the other version using the canApprove/hasApproved flags . In the current version it is not well tested and has two issues I'm not happy with: 1....

@erbrecht I'm still hoping it'll get merged. Initially I had wanted to rewrite it slightly to consider the new flags, but lacked the time to rewrite it with the proper...

It's been a while and I don't use Jenkins at my current position so I'm no longer pushing this actively. But I'd still be willing to get this back into...

I skimmed through the documentation of the remote API. Most of the current configuration won't need to be changed. The changes that would likely be needed: **Cloud configuration:** - Mode...

> can standard docker client work with docker engine that in swarm mode? Yes, but any containers started via the regular container API (/containers/create) will be created on that specific...

@KostyaSha Can we assist you in some way to get this moving? Help fix integration tests in docker-java, help with architecture sketches here, or something else?

> But swarm mode is not needed for this plugin as jenkins should have exact mapping. I think swarm cli is the only useful thing for orchestration. Could you elaborate...

I see - my assumption for a possible solution was to use the Docker Remote API for services and to adapt the plugin to: - For each starting job (cloud...

> So you will have a lot of similar services? Yes, we'd have a lot of similar services if implemented that way, because we'd not care about scaling. We checked...