Vladyslav Nikonov

Results 33 comments of Vladyslav Nikonov

2 additional observations: 1) we calculate `uncompressedLength` for `ShareDataHeader` [differently](https://github.com/Devolutions/IronRDP/blob/master/crates/ironrdp-pdu/src/rdp/headers.rs#L257-L259) from FreeRDP, we include pdu type/compression fields size, while FreeRDP don't. Pretty sure this is bug on our side. However...

> Interesting findings though it's not clear why this would cause a change in behavior before/after resize. Does the 30ms change before/after? Is FreeRDP's substantially faster? Oof, I was re-validating...

Thanks for the contribution! I'll review it this week! I see that CI has started failing, I'll look into that

Nice, great job @ArjunNair ! 🔥

Huh, Github shows "This branch cannot be rebased due to conflicts" error.... Could you try running `git rebase master`? and fix the conflicts? If not, I could merge manually a...

![image](https://github.com/rustzx/rustzx/assets/3994505/32c5b467-3155-4c5d-98d9-e01b8b4fff28) @ArjunNair yep, somehow github still detects conflicts 😢

Github is weird sometimes, I'll merge it manually on weekends

@ArjunNair I found the issue, your fork has diverged from rustzx's current master, you should rebase your fork master instead of merge commit next time, there are 2 already merged...

I squashed and rebased the commits, currently trying to merge this here: https://github.com/rustzx/rustzx/pull/141