packageurl-python icon indicating copy to clipboard operation
packageurl-python copied to clipboard

Validate `vers` qualifier

Open jaimergp opened this issue 9 months ago • 9 comments

Goes with https://github.com/package-url/purl-spec/pull/433

jaimergp avatar Mar 30 '25 18:03 jaimergp

@jaimergp Thanks! can you add a few simple unit tests?

pombredanne avatar Apr 30 '25 15:04 pombredanne

@pombredanne, done!

jaimergp avatar May 08 '25 19:05 jaimergp

The mypy errors are external to this PR. We are now importing univers, which doesn't feature the py.typed marker file, so mypy complains it won't infer types from that package.

The solution is to add type hints to universe or ignore the import here. Thoughts @pombredanne @mprpic?

jaimergp avatar Jun 10 '25 18:06 jaimergp

As discussed in today's meeting with @pombredanne, I added https://github.com/aboutcode-org/univers/pull/159 to tame the CI here, which is the simplest PR possible to fix this and let mypy infer things in univers.

jaimergp avatar Jun 25 '25 16:06 jaimergp

https://github.com/aboutcode-org/univers/pull/159 was merged a while ago, we just need a new univers release in PyPI and the CI will be green here.

jaimergp avatar Jul 23 '25 13:07 jaimergp

@mprpic @pombredanne - is there anything I can do to request a release for univers so we can get this CI green and then push a packageurl-python release? Thank you! 🙏

jaimergp avatar Sep 11 '25 11:09 jaimergp

@jaimergp https://github.com/aboutcode-org/univers/tree/v31.1.0 tag and https://github.com/aboutcode-org/univers/releases/tag/v31.1.0 release on GH are ready, will reflect on Pypi on a few.

TG1999 avatar Sep 11 '25 11:09 TG1999

CI is finally green 🥳

jaimergp avatar Sep 17 '25 17:09 jaimergp

Gentle ping @pombredanne

jaimergp avatar Nov 26 '25 09:11 jaimergp