José Pacheco comments

Results 9 comments of


                                            José Pacheco

Add missing import of 'invariant' function

Fixes #60

Fixes #417: Remove extra files in npm package

Noting I took this config from https://github.com/ccampbell/mousetrap/issues/417#issuecomment-451399736

Minify npm package size

any updates on this change? In addition to the bloat, the current `tests/` dir contains an outdated/vulnerable version of jQuery (which is probably fine for tests, but not great to...

[Python] Make MARITIME_TRADE action's value a 10-integer list

Shouldn't this be two arguments? as in `Action(Player, Action.Trade, (GiveFreqdeck, ReceiveFreqdeck))`. Any reason why you decided to concatenate them?

[Python] Remove nxgraph dependency

At the very least, it looks like we can move the dependency to catanatron gym, as all of the production usages are there (we define the graphs in catanatron.models.board, but...

[Python] Remove nxgraph dependency

where's the 72 coming from?

Simulator CLI seems to ignore first player code in list and also fails with 5 or longer (thus preventing a 4 player workaround)

Hi @ptudan, are you able to fork the repo and open a PR against this repo from your fork? On the specific issue, I believe the click library is parsing...

Implement fast c++ version of graph functionality

On that note, I'm wondering if we can completely replace nxgraph here - see https://github.com/bcollazo/catanatron/issues/76

Implement faster winner check

in general I like this direction. I do agree we should check if the player has won after every action taken. Catan _does_ require that you win in your turn,...