Pablo Sichert
Pablo Sichert
This PR is indeed some nice work, @leifhelm! I've been working on wrapping the LLVM ORC API before I stumbled on this, and thought I'd rather invest my time to...
@leifhelm sure, you can find my implementation that I added on top of your branch here: https://github.com/pablosichert/inkwell/commits/orc2. The commit specifically to implement `JitDylib::add_generator`/`CustomDefinitionGenerator`: https://github.com/pablosichert/inkwell/commit/e335e56c4f293a6e0ef22d062bce8483cf3ec6d0. Feel free to pick from that...
@leifhelm hah, yes good catch. I had a segfault locally that boiled down to the generator being dropped when the JIT was still alive. I left a suggestion on your...
I'm blocking this issue on https://github.com/rust-lang-nursery/glob/issues/59#issuecomment-762673096 due to https://github.com/timberio/vector/pull/5927#issuecomment-757759659.
Alternatively, there is [`libc::glob`](https://docs.rs/libc/0.2.82/libc/fn.glob.html) which we could use on Unix. Haven't found anything comparable for Windows yet. Edit: Nevermind, that one doesn't support patterns to recursively descend directories, like `./**/foo.txt`.
I think we could run into a problem here - for the first render the parent node is never present, since the mount order of react is `Child -> Parent`....
I agree that the infinite loop is all but optimal - but how do you expect the component to behave once the parent gets visible? We can either: - not...
I have created a sandbox with your example (https://codesandbox.io/s/6yj42pmlww) but can't reproduce what you are describing. Please clarify if I misunderstood your problem. Could you edit the sandbox and send...
Changes look good! Let's come back to this after merging and rebasing on https://github.com/One-com/react-truncate/pull/37.
The library already does the "hacky" thing by listening on the `resize` event and calling `calcTargetWidth`, just like you do. You could improve it a bit by only calling it...