pablosaavedra-rappi

Results 8 comments of pablosaavedra-rappi

Thanks for the comment, will look into it and update the PR.

You could workaround your issue by explicitly obtaining the connection instead of calling execute directly. That way, the connection timeout setting of the pool will be honored and you'll get...

@ashertarno Any chance you can build and try your use case with this branch? https://github.com/pablosaavedra-rappi/vertx-sql-client/tree/fix/honor-connection-timeout

Ok, just confirmed that with my changes your code exits with a timeout (it doesn't with branch 4.x)

@vietj finally got around to working on this one. I rebased with the 4.x branch and added the changes you requested. Let me know if you have any other comment....

One question, tho: I see that the `src/main/generated` folder is checked into version control. Should I push the class that changed there, too?

So @vietj you are suggesting we overload the method with an additional `scheduleTimeout` parameter and the behavior there? I can check how that'd look and update the PR.