Povilas Kanapickas
Povilas Kanapickas
Tests need an update, but otherwise looks good.
Live update works as follows: - We subscribe to a REST query with WebSocket updates via a call to `useDataApiQuery` which returns an instance of `DataCollection`. - `DataCollection` tracks what...
Looks good. We now need tests, documentation update and a release note.
Addressed constness comments. It would have been enough to point just one case and add "and elsewhere", I would have fixed all occurrences. About constness itself, personally I don't like...
> IMO, const helps readability. Each declaration without a const means that it will be modified, that's very useful to quickly read an algorithm. Fair enough. > I'm not sure...
I will prepare a single PR with all changes.
LGTM, I pretty much had to implement the same fixes in my own builds scripts that don't use ExternalProject_ADD.
This PR could be 2 or 3 PRs which would be easier to merge than one large PR. E.g. Vector2d -> Vector2f changes could be a single PR. This introduces...
@servantftechnicolor I can rebase the `mergeCalibration` branch and solve the conflicts.
This PR is much smaller change so it makes sense to get it in first and then larger, more risky changes on top.