Povilas Kanapickas

Results 417 comments of Povilas Kanapickas

> I am not sure what is the purpose of some of the tests I will add docstrings where I can. Some of the tests were just moved, so I...

> If you find a randomly failing tests, please add info about the test name or a link to the build It was not the tests themselves that were failing....

Thanks for explanation, it all makes sense.

I've applied all suggestions.

I've updated the PR and fixed tests. Measured the performance: the tests, measurement scripts and results are located at https://github.com/p12tic/gist-twisted-perf-tests. I'll edit the description with the results.

When reviewing, please verify the correctness of the explanatory comments I've added. They show how I understood the current Twisted codebase and if I did an error there, then further...

Looks like I confused myself about the actual amount of improvement. I've updated the format of comparisons in the linked tests repo to reduce the chance of this.

Hey @glyph, thanks for review. I didn't have time to go back to this PR so far, but expect to be able to do so in the following week. I...

I think I could try to resurrect this.