Roman
Roman
I'm going to merge this. `CalcJoinPoolNoSwapShares` can be addressed in a follow-up PR
Benchmark at commit: [d6324f4](https://github.com/osmosis-labs/osmosis/pull/2788/commits/d6324f4867570af2c42910c64ec1f41bfcaf82bd) ``` goos: linux goarch: amd64 pkg: github.com/osmosis-labs/osmosis/v12/osmomath cpu: 12th Gen Intel(R) Core(TM) i7-1260P BenchmarkLog2-16 7366 146285 ns/op 67907 B/op 1236 allocs/op BenchmarkLog2-16 8853 141121 ns/op 67944...
According to benchmarks, reducing the log to be between `[1, 1.0001)` ends up being much less performant. More than 5500 iterations for log base 2 of 3. With the current...
I like the idea. I think we should also invest in documenting how to identify state-breaking changes in `CONTRIBUTING.md`
> Let me think about the possible edge case here, is it going to error when the pool does not have the last spot price? By last spot price, are...
Decided on the call that this is not v12 blocking but good to have in the future releases
@catShaark I would love to work with you on smaller batch writing. Would you be interested in working together?
I agree that the test we have covers most of the logic we want. However, it's a functional test rather than a unit test. It is useful to have both....
Converting this to Epic
@nicolaslara when you get the time, do you mind linking all relevant PRs one could follow about this feature?