OZAWA Tsuyoshi

Results 17 comments of OZAWA Tsuyoshi

Hi @xerial and @muga, IMO, Plan 2 looks much simplest way to implement and use. I believe that it can be implemented straightforwardly. Is the error handler interface like this?...

Thanks for your contribution, @takawitter! I've checked the overview of your commits, and it seems to take a bit of time to review. Could you wait a moment? Thanks, Tsuyoshi

@takawitter: I ran `mvn test`, but `org.fluentd.logger.sender.TestRawSocketSender` fails unfortunately. Could you fix it at first? The log is as follows: ``` Running org.fluentd.logger.sender.TestRawSocketSender 2013/09/05 23:11:36 org.fluentd.logger.sender.RawSocketSender open fatal: Failed to...

Oops, I have a mistake about my local branch management. Thanks for your point, and please wait a moment.

The confusing log message at testing is filed as #7. Thank you for reporting. The review comment is as follows: could you explain your use case? Other loggers(e.g. fluent-logger-ruby) doesn't...

Or, if we can design the feature more simply, I'd like to merge your pull request. Now I'm thinking more simple one.

I apologize for the delay. The use case you pointed out looks good to me. Thank you for the sharing :-) The review comment against the implementation: IMHO, it's enough...

> > IMHO, it's enough for users to support message-packable events. These include the events as follows: > > 1. events which is annotated as `@Message`, `@Beans`. > > 2....

@komamitsu @muga do you have any suggestions about this?

Added [QuickStart page](https://github.com/msgpack/msgpack-java/wiki/QuickStart) on github Wiki.