Oscar Vestlie
Oscar Vestlie
This change can probably go in as-is. There was some follow-up required to get this to work on our internal build system as well.
Looks good from my POV
Just saw that the linter failed on this PR. The generation scripts don't generate linter approved markdown so you need to run the linter locally before uploading. I'll update the...
Converting to draft until I've dealt with the comments.
This is ready for a new review. I've addressed the comments and removed additional blocks that I had previously missed.
I'm closing this PR in favor of #3247.
This change needs an internal change to be deployed before landing.
I pushed a new commit that accommodates the internal change that also uploads the logs files to GCS.
The solution proposed here is not ideal. `test_runner.py` should be platform agnostic and use the launcher to deal with specifics.