Frames White
Frames White
This matches to https://github.com/FluxML/Zygote.jl/pull/794 Fixing this in chainrules won't actually fix it in Zygote becuase Zygote defines `sum(::AbstractArray)` with a better definition than what ChainRules has right now, that will...
Like https://github.com/JuliaDiff/ChainRules.jl/issues/154 I am pretty sure there is a generic rrule for constructors. Pretty sure I even wrote it down somewhere. It is something like ``` function rrule(::Type{T}, args...) where...
This is the outcome of a discussion I had with @KristofferC about how to make glue packages work. We should put it into practice for SpecialFunctions.jl and NaNMath.jl We make...
I see in https://github.com/JuliaDiff/ChainRules.jl/blob/master/src/rulesets/LinearAlgebra/factorization.jl we use a fair bit of `A'` which is `adjoint`. In other places @simeonschaub has said we need to not use that, and to use `transpose`...
@sethaxen wrote in https://github.com/JuliaDiff/ChainRules.jl/pull/279#pullrequestreview-506908830 > not allocate new conjugated matrices in the BLAS rules? e.g. in > > https://github.com/JuliaDiff/ChainRules.jl/blob/c877550430a3cb0f657f43ccbf4e64b13b7177a7/src/rulesets/LinearAlgebra/blas.jl#L134-L137 > , > we allocate a new matrix `A`, which I...
- https://people.maths.ox.ac.uk/gilesm/files/NA-08-01.pdf - QR: https://arxiv.org/pdf/1001.1654.pdf
Since checkpointing can be implemented as a sensitivity, it may very well belong here. See: - Nabla: https://github.com/invenia/Nabla.jl/pull/171 - Zygote: https://fluxml.ai/Zygote.jl/dev/adjoints/#Checkpointing-1 - Tracker: https://github.com/FluxML/Tracker.jl/blob/bd98dab59026eb753c296a5f19367a408c2cb8b6/src/Tracker.jl#L82-L89
Some of the code used `zero(X)`, or `@thunk(zero(X))` I feel like if `Zero` is working right we should be able to replace that with `Zero()` E.g. https://github.com/JuliaDiff/ChainRules.jl/blob/master/test/rules/linalg/factorization.jl
not done in https://github.com/JuliaDiff/ChainRules.jl/pull/173 because https://github.com/JuliaDiff/ChainRulesTestUtils.jl/issues/22#issuecomment-615961039 (which blocks this issue)
We still use a explict seed for testing `mod` and `rem`. During #185 I removed it and those tests failed. I have not investigated closely, it could be they are...