Owen Brooks

Results 12 comments of Owen Brooks

> 1. Why is e.g. Scale normal using `[1.0, 2.0]` but Scale alternative `[1, 2]` (the `.0` part)? Shouldn't it be either the same or even the other way around?...

> This is reasonable, but IMO consistency is more important. It's really weird for one type to have exactly the opposite behavior of the others. I agree with @Andlon that...

I've reworked it a bit as follows: - Display is 2D pretty-print by default and does not include type names. - Display alternate prints matrices and geometry-vector types on a...

Yep that makes a lot of sense. Thanks for your explanation! How is this: ``` ========================== Display ┌ ┐ │ 1 2 3 4 │ │ 5 6 7 8...

> Thanks, I'm much happier with that (and I appreciate your patience working through all these drafts!). I like what you did with the Debug Alternate format too; that's a...

New output ``` ================== Point ================== Normal ┌ ┐ │ 1.12345678 │ │ 2.12345678 │ │ 3.12345678 │ └ ┘ Alternate [1.12345678, 2.12345678, 3.12345678] Debug [1.12345678, 2.12345678, 3.12345678] Debug alternate...

That does seem simpler, thanks. I've made that change. Which other flags were you expecting it to handle when forwarding? From what I can see it looks like the underlying...

The Isometry, Scale, Rotation, and Translation types all have similar Display impls that only pass through precision and have similar wrapping with “Typename {“ and “}”. I would prefer omitting...

> (reporter of the referenced issue here) Hm, I actually liked the concise single-line form of Point, while the new form makes it a bit more verbose. > > I...

I've tried to reduce these inconsistencies in #1119. Would appreciate feedback!