ovsep404

> Reasonable - THX - please try to add a unit test - thx Thanks @DeepDiver1975 ! I've added [unit test](https://github.com/jumbojett/OpenID-Connect-PHP/pull/466/commits/08f5906ff1d1d4e280d28b8a1cad71742d0b7e03) for the Basic Authentication header construction. The tests cover:...

> This urlencode was added in #192 as RFC 6749 (OAuth 2.0, https://datatracker.ietf.org/doc/html/rfc6749#section-2.3.1) mentions this encoding. > > > The **client identifier is encoded** using the "application/x-www-form-urlencoded" encoding algorithm per...

> Also this commit for the apache module [OpenIDC/mod_auth_openidc@aa20bd9](https://github.com/OpenIDC/mod_auth_openidc/commit/aa20bd982ab6661d647d9b6dda6b73d08db285ad) > > and this issue for the nginx plugin [zmartzone/lua-resty-openidc#204](https://github.com/zmartzone/lua-resty-openidc/issues/204) Thanks for the follow-up! It’s true that some libraries like mod_auth_openidc...

> I guess we will not be able to find a solution that works for everyone. My understanding of the specs is that it should be encoded, however reality shows...