Claudio Wunder

Results 1165 comments of Claudio Wunder

> stuck with `next-data` which is giving me a hard time Can you share your difficulties?

> > Can you share your difficulties? > > It's junior's problem. But I don't know what to test. And I don't know where the line is between mocking data...

> someone can run the tests on his machine, because on mine it works. Yes, it sounds like a joke, but it's really strange. And yes, I did push my...

@AugustinMauroy I guess I messed up on the rebase, can you fix it?

> > @AugustinMauroy I guess I messed up on the rebase, can you fix it? > > always a pleasure to fight with Jest It's more like the file was...

(You can address that on a follow-up PR)

> The breadcrumbs on the Learn pages display "Diagnostics" regardless of what module the page actually falls under. The breadcrumbs should dynamically update to reflect the correct module. This issue...

> > > The breadcrumbs on the Learn pages display "Diagnostics" regardless of what module the page actually falls under. The breadcrumbs should dynamically update to reflect the correct module....

> I think we can add a prop in [BaseApp](https://github.com/nodejs/nodejs.org/blob/main/next.app.tsx?rgh-link-date=2023-06-29T15%3A24%3A06Z#L26) to indicate if it's being rendered in Storybook or not. If yes, we'll supply the data from the [fixture](https://github.com/nodejs/nodejs.org/blob/main/__fixtures__/nodeReleases.tsx?rgh-link-date=2023-06-29T15%3A24%3A06Z). I...

Our App should not have test-specific logic. The testing environments should be able to mock/spy on the real stuff.