Claudio Wunder
Claudio Wunder
Note that this version of the ChangelogModal does not include the avatars of all contributors that made a release happen. We still need to hook this into some internal utility...
> I compared the page source sizes for the two versions: > > [With changelog](https://nodejs-lhta2c4o3-openjs.vercel.app/en/download) modal; Source size: `193.85 KB` > > [Beta](https://beta-node-js-org.vercel.app/en/download) without changelog modal; Source size: `86.65 KB`...
> Something feels weird with how the page seems to disappear entirely with no UI element to close the modal. Indeed, I assume we need to add an X button....
Right, the intent of this PR was to solve the issue we have of changelog rendering on GitHub. But it would only cover/handle cases for the current LTS and current...
> > One of the other goals of this Modal, was to have a collection of GitHub avatars rendering, that showcase all the committers that made said release possible, and...
> > (Also @richardlau I pinged you here because I recall you mentioning there was a way to get a list of all committers of a release, can you point...
@canerakdas could you rebase? And @bmuenzenmeyer could you re-review?
@canerakdas I believe we need to reduce blur and add a close button. Also the changelog should only open after finishing fetching the data (IMO)
Awesome! Would it also bee too much to ask you to check into what Richard mentioned ([changelog-maker](https://github.com/nodejs/changelog-maker) pulls the information out of the git commits.) for getting the full list...
I believe we can merge this as it is; But we need reviews cc @bmuenzenmeyer @nodejs/nodejs-website