Claudio Wunder

Results 1165 comments of Claudio Wunder

Hmm I gotta give a look if we are automatically consuming https://vercel.com/docs/environment-variables/framework-environment-variables#NEXT_PUBLIC_VERCEL_URL as a fallback. Anyhow, we can revise that logic in a future + adding some extra docs. But...

This sounds interesting. Strong +1

I appreciate the effort, Jordan (don't want to discredit it), but this PR is a strong :-1: for me. Opinions, cc @nodejs/nodejs-website?

> I mean the solution is hacky indeed, but at least it works, no? 😅 #8328 still shows `x64` for me on Safari on an M1 device I'll investigate what's...

> I can certainly add tests. I verified that it returns true in Safari on my M4 Mac. As for "hacky", using a Chrome-only nonstandard feature is FAR more hacky...

> @ovflowd that link is explicitly to a draft, which means it's not actually standardized yet. To compare to TC39, it'd be like if a feature was shipped prior to...

Hey @ljharb I wanted to publicly apologize as after re-reading my own comments here, I happened to notice that I was unnecessarily hostile here and provocative. Whilst these were not...

Did the PR become stale? Is there anything needed here to unblock?

cc @nodejs/web-infra / @nodejs/nodejs-website if anyone wants to tackle this. Would be a quite fun task :)

Based on https://github.com/nodejs/nodejs.org/pull/7758#pullrequestreview-2866834882, y'all can see I'm -1 with the idea of having WSL notices within our website. There's no precedence in other major runtimes for something such as WSL...