Yufan You

Results 268 comments of Yufan You

> Compared to #919 , this gives the user more freedom No. Users can start a terminal and cd to the desired directory with #919, so #919 is more powerful,...

> The point with embedded is that it can be more deeply integrated to the editor, with features like Meta+T to switch to the terminal, etc, etc. That should be...

@swift-zym Can you test removing this based on master: https://github.com/cpeditor/cpeditor/blob/09216ba172a46f3c48f491ca95673f956c124971/src/Widgets/RichTextCheckBox.cpp#L71

If https://github.com/cpeditor/cpeditor/pull/902#issuecomment-874777307 works, use that solution; else if 4d784c3f528773d4bcff2df52de86e1dac46492e works, use it; if neither of them works, revert 4d784c3f528773d4bcff2df52de86e1dac46492e.

What is the value of `style()->pixelMetric(QStyle::PM_CheckBoxLabelSpacing)` in macintosh theme?

Does 4d784c3 add a spacing, though not necessarily wide enough?

I just think it's not very good to hardcode a spacing size for a specific theme, as the theme may change in the future :thinking:

Or we can try to find a different way to implement #733.

> if it's a macOS Qt Style bug, instead of code change we can report/wait for Qt to fix it. This is a custom widget, so we need to find...

It's related to restoring the test case sizes: https://github.com/cpeditor/cpeditor/blob/3ffe83a43596f926d4d7206220828049abd77a37/src/Widgets/TestCases.cpp#L418-L440 Maybe we don't need to restore the sizes.