Oussama Jarrousse
Oussama Jarrousse
The list of user-agent strings on https://useragentstring.com/ is outdated. Any idea on how to update the list on that website, and then keep it up to date? Or maybe it...
I was trying to include the allauth urls in a [namespace](https://docs.djangoproject.com/en/5.0/topics/http/urls/#url-namespaces) as in: ``` urlpatterns = [ path('v1/accounts/', include(('allauth.urls', 'allauth'), namespace='v1')), ] ``` The named urls are now all behind...
Pylint is a linter for python, there are several plugins for different frameworks and use cases such as the pylint-django plugin. Using pylint with pylint-django plugin I got the following...
I suggest adding tests with PyTest. If you like the idea, and you approves I will volunteer to create the boilerplate and the first few tests.
Currently the User_Keys model in models.py, uses `username=models.CharField(max_length = 50)`. This could be problematic in case the django app allows for changing the `username` for example. Also deleting a user...
in the `class Hash` in `recovery.py` you can see the following: ``` class Hash(PBKDF2PasswordHasher): algorithm = 'pbkdf2_sha256_custom' iterations = getattr(settings,"RECOVERY_ITERATION",1) ``` in the case RECOVERY_ITERATION was not defined in settings.py,...
The function genTokens in recovery.py generates `5` tokens by default: ``` @never_cache def genTokens(request): #Delete old ones delTokens(request) #Then generate new one salt = randomGen(15) hashedKeys = [] clearKeys =...
While reviewing the django-mfa2 code, I noticed that `settings` is being referenced without being imported in `Email.py` Or am I understanding something wrong?
## Summary of the changes in this pull request * TODO ## Pull request checklist - [ ] I have added an entry in `CHANGELOG.md` including my name and issue...
QuerySet class in MongoEngine does not have .model key as the in the QuerySet class as defined in django.db.models.query.QuerySet. adding this field to queryset on initialization could allow for better...