othercorey

Results 200 comments of othercorey

Is there a way we can detect this without much overhead?

> You don't necessarily have to provide a complete working sample, the association configurations of your 3 involved tables might already be enough for someone to be able to reproduce...

`clearResults()` was added in 3.9 - https://book.cakephp.org/3/en/appendices/3-9-migration-guide.html#orm

> Oops, I thought I've seen a `@since 4.0.1` tag, but I must have mixed that up. Still a valid suggestion I'd say, further changes would end up in 3.9...

I think we need https://github.com/sebastianbergmann/phpunit/issues/3795 implemented to move away from inherited TestSuite. This would let us bootstrap the database suite with different configurations as unique test suites for filtering too.

I removed the use of TestSuite from our internal tests. Now we run phpunit twice. https://github.com/cakephp/cakephp/pull/15844 I don't know if we should deprecate/remove TestSuite.

I looked into the use of AssertionFailedError. These could really just throw another exception to fail the test since they are configuration errors. The use of `$this->fail()` doesn't really work...

Closing this. Think we have to wait to see what PHPUnit 10 provides us. The use of TestSuite was removed.