othercorey comments

Results 234 comments of


                                            othercorey

Correcting getGlobalSchemaName to use the correct schema

@markstory might be already out for CakeFest. I will check this out if he's not available for a long time.

Testing commands with `RunInSeparateProcess` and connection

How do you know it's using the "default" connection? Which database engine do the tests use?

Testing commands with `RunInSeparateProcess` and connection

@markstory Did you create a test we can commit or is it not something that fits into our test suite?

Testing commands with `RunInSeparateProcess` and connection

We might have to accept limitations of using RunInSeparateProcess, but I think that will be hard to document clearly and users would run into this issue before finding that.

2.x: Dirty state after tests

Baking the files into the test_app directory is really annoying since sometimes they aren't wiped out on a failure.

Install rector, add rector config, add rector changes, add rector for CI

I would agree that rector is not our coding standard. We don't need another large static analyzer running on each commit.

dev doesn't seem to tail logs or forward ports

You have to specify `--port-forward` with `skaffold dev`

Fix(Database): Ensure read/write settings correctly inherit shared config

Surprised we didn't use any shared config values in other tests.

Fix(Database): Ensure read/write settings correctly inherit shared config

Windows does not include the mysql driver so the test is failing.

Fix(Database): Ensure read/write settings correctly inherit shared config

I think the failures are unrelated.