cakephp icon indicating copy to clipboard operation
cakephp copied to clipboard

Install rector, add rector config, add rector changes, add rector for CI

Open Harfusha opened this issue 1 year ago • 4 comments

Harfusha avatar Sep 13 '24 07:09 Harfusha

https://github.com/cakephp/cakephp/issues/17865

Harfusha avatar Sep 13 '24 07:09 Harfusha

I am not in favor of adding rector as a dev dependency, nor running rector as a part of CI, that's wasteful.

These pedantic opioniated changes don't fix any actual problem nor bring any significant performance gains.

We can instead have a separate workflow which runs on a weekly basis and reports the diff or auto create a PR which we can review.

ADmad avatar Sep 13 '24 11:09 ADmad

We can also just composer require it at runtime directly inside the job. Thats probably best.

dereuromark avatar Sep 13 '24 13:09 dereuromark

I would agree that rector is not our coding standard. We don't need another large static analyzer running on each commit.

othercorey avatar Sep 13 '24 15:09 othercorey

Do you want to refactor similar to other analyzer tasks to run only in ci? Without modifications to Code base?

dereuromark avatar Nov 19 '24 07:11 dereuromark

ping @Harfusha

dereuromark avatar Dec 26 '24 20:12 dereuromark

Sorry i dont have any time right now. I will look into this issue when i find some free time

Harfusha avatar Jan 06 '25 06:01 Harfusha

https://github.com/cakephp/cakephp/pull/18625

dereuromark avatar May 05 '25 00:05 dereuromark