cakephp
cakephp copied to clipboard
Install rector, add rector config, add rector changes, add rector for CI
https://github.com/cakephp/cakephp/issues/17865
I am not in favor of adding rector as a dev dependency, nor running rector as a part of CI, that's wasteful.
These pedantic opioniated changes don't fix any actual problem nor bring any significant performance gains.
We can instead have a separate workflow which runs on a weekly basis and reports the diff or auto create a PR which we can review.
We can also just composer require it at runtime directly inside the job. Thats probably best.
I would agree that rector is not our coding standard. We don't need another large static analyzer running on each commit.
Do you want to refactor similar to other analyzer tasks to run only in ci? Without modifications to Code base?
ping @Harfusha
Sorry i dont have any time right now. I will look into this issue when i find some free time
https://github.com/cakephp/cakephp/pull/18625