othercorey comments

Results 245 comments of


                                            othercorey

Authentication->setIdentity isn't respecting Session.ini.session.cookie_path

@patrickconroy Can you follow up on this?

5.0 - Database & ORM package changes

@markstory Do we have anything left to track?

sphinx php parameter rendering hard to read

Thanks!

Add @phpcsSuppress to `Command::execute`

Re-opened so we can follow up with the recomendation.

nullable return types in CallMap functions technically correct but make no sense

@orklah Just went through this function in the callmap tests. It will return null if CURLOPT_RETURNTRANSFER is not set. I've patched the php docs but will leave this ignored.

[4.next] Comment out ellipsis for better copy-paste-ability

Why do this in 4.next?

#16746 Change required class

@markstory Going to assign this to you to close out

Consider allowing unbuffered queries for ORM SelectQuery

Why can't you buffer the results from the first query?

Consider allowing unbuffered queries for ORM SelectQuery

So you worker is batching jobs by pulling N records from this first query then building the rest of the data just for that set and then releasing the data...

Consider allowing unbuffered queries for ORM SelectQuery

FYI - we are considering this, but don't have an immediate solution.