Adam

Results 12 comments of Adam

> cc @oswian if that's what you had in mind. :) Thanks for working on the tests @Aurorum. I have a few suggestions: - Avoid re-implementing the `useHandleClickLink` logic inside...

Thanks for addressing my feedback @Aurorum. > I thought it might be helpful if I clarified that my intention for that test was to prevent a repeat of https://github.com/Automattic/wp-calypso/pull/87474, which...

Seeing a build [error](https://teamcity.a8c.com/buildConfiguration/calypso_calypso_WPComPlugins_Build_Plugins?branch=%3Cdefault%3E&mode=builds#all-projects) on `trunk` which appears related to this PR.

@chriskmnds Sure, either approach works for me. The approach I adopted here seemed most efficient -- find a logical home for each component, and then address style changes in a...

@chriskmnds Thanks for taking a look over this. > I mainly wanted to highlight that we need to gradually be "fixing" internally where it needs fixing (classes, names, styles, etc.)....

Thanks for the review @southp. > It works for me functionally, but somehow the dismiss button is misaligned for me. It's not the case in the screenshot though. Great catch....

🤔 Hmm, seeing a build error on the step: `Build Calypso Apps (WPCom Plugins)` The [build log](https://teamcity.a8c.com/buildConfiguration/calypso_calypso_WPComPlugins_Build_Plugins/11948960?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildProblemsSection=true&showLog=11948960_3084_2987&logFilter=debug&logView=flowAware) doesn't suggest the changes here are the cause. I'll rebase and see if...

> I'll rebase and see if that does the trick. Rebase did not resolve the build error. This makes sense - I see there is a [build error](https://teamcity.a8c.com/buildConfiguration/calypso_calypso_WPComPlugins_Build_Plugins/11948590?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildProblemsSection=true&expandBuildChangesSection=true) on `trunk`....

> That should be all that's needed. Since it's unrelated to this PR and isn't blocking, please feel free to deploy it. Ok will do 👍

> I changed the color as adviced in the ticket Hmm, I'm still seeing the filled buttons. Perhaps the change hasn't been pushed, as I don't see any new commits?...