osulzhenko

Results 27 comments of osulzhenko

> First of all: kudos to the structure of your functional tests. Super comfortable to read and understand. Even though most of them look like they could be unit tests...

> > @SerhiiNahornyi , @marki1an I need to push back on some of the failing tests, as they are currently very hard to implement. > > The [StoredDataResult](https://github.com/prebid/prebid-server-java/blob/master/src/main/java/org/prebid/server/settings/model/StoredDataResult.java) model contains...

> @osulzhenko anything that blocks this? @muuki88 Not from my side. You need to get approval on your original PR https://github.com/prebid/prebid-server-java/pull/2733

@zapo, pls fix pom conflicts: ``` Error: ] Some problems were encountered while processing the POMs: [FATAL] Non-resolvable parent POM for org.prebid.server.hooks.modules:optable-targeting:3.26.0-SNAPSHOT: The following artifacts could not be resolved: org.prebid.server.hooks.modules:all-modules:pom:3.26.0-SNAPSHOT...

@danielbaud any updates on this one?

@Net-burst does this PR still make sense to keep open?

@andreacastello could you please resolve conflicts?