Oliver Steele
Oliver Steele
I'm wary of introducing a difference from the Shopify specification. Aside from this, this seems like an improvement, that would be useful for users who are not concerned about compatibility...
This issue can be addressed by creating a PR against [SlinSo/goTemplateBenchmark](https://github.com/SlinSo/goTemplateBenchmark): * Add this package to `glide.yaml` * Create a `liquid` folder; * Translate at least the `simple.*` template from...
I've created a related issue #32, to add benchmarks to this (`osteele/liquid`) repository. This can be done independently of creating a PR to add timings to [SlinSo/goTemplateBenchmark](https://github.com/SlinSo/goTemplateBenchmark), except that the...
This looks like a very well-thought-out proposal and I'd be happy to have it in the project. I'm sorry for the very long delay in my reply, and I hope...
PR #41 could use this
That is correct, this library does not support named arguments to filters. (In fact, I did not know that Shopify did.) I would be interested in having a fix for...
Here is documentation for Shopify's `image_url` parameters: https://shopify.dev/api/liquid/filters/url-filters#other-image-url-parameters Here is a test case for filter parameters in the Ruby implementation's parser: https://github.com/Shopify/liquid/blob/9b8e3d437e1ac461fc32bd896e7f35dfa8b94a2a/test/unit/parser_unit_test.rb#L73 (from [this bug report](https://github.com/Shopify/liquid-c) against the C implementation...
I'll look at the coverage. Do you happen to know how this tracks the reference (Ruby) implementation of Liquid? Does it make it more or less like Ruby Liquid? (I'm...
@sgargan can the [whitespace control options](https://shopify.dev/api/liquid/basics/whitespace) be used to do what you want?
Here's what I can think of: - The code, and the included filters and tags, don't access the disk or network. - It is trivial to write a template that...