Gocha Ossinkine
Gocha Ossinkine
@julienfalque @SpacePossum @mvorisek @kubawerlos @GrahamCampbell Hey guys, could someone review this?
@kubawerlos @mvorisek fixed
@kubawerlos @mvorisek Hey guys, tests are passed, let's merge this if everything is ok
@GrahamCampbell I've ran the fixer on symfony/symfony and there was no fixes, but I guess it's so because Symfony doesn't use this fixer
@GrahamCampbell I've ran this fixer on symfony/symfony and found some issues, fixed them and added tests. Please review again.
There are already a lot of cases with comments, so please specify what exactly cases you want to add. Like the following? ```php $this ->first() // first ->seconds() //second ->third()...
@mvorisek Looks like the fixer works correctly on your case: ```diff --- Original +++ New @@ @@ ->field('amount', 'debit') - ->field($this->q()->expr('0'), 'credit') // simply 0 -; + ->field($this->q()->expr('0'), 'credit'); //...
@keradus why we can't merge it and you fourth time move the milestone?
@kubawerlos I've solved the conflicts and changed the target branch, let's merge
@keradus you've changed the target branch to `master`, but @kubawerlos requested to change to `3.0`. What is correct branch?